FidelityFX-SDK icon indicating copy to clipboard operation
FidelityFX-SDK copied to clipboard

FSR3 sample crashes when setting Letterbox Size to 0.0

Open Calinou opened this issue 1 year ago • 1 comments

The FSR3 demo from this SDK crashes if setting Letterbox Size to 0.0 in the control panel by dragging it all the way to the left, likely due to a division by zero. I suggest clamping its lower bound to something like 0.1 to avoid this.

PS: This setting performs letterboxing on both axes, not just the Y axis (so the aspect ratio remains the same). Is that intended?

Calinou avatar Jul 14 '24 19:07 Calinou

Thanks for bringing this to our attention. I've just fixed it in our internal mainline. Will be fixed here next time we update.

With regards to your question, yes it was intentional. We just wanted a quick test to show cropping could be applied and just chose to do it that way. The x and y ratios can be set individually.

jlacroixAMD avatar Jul 15 '24 00:07 jlacroixAMD