FidelityFX-SDK icon indicating copy to clipboard operation
FidelityFX-SDK copied to clipboard

ffx_fsr3.cpp ffxFsr3ContextDestroy crash

Open svatostop opened this issue 1 year ago • 1 comments

Hi! We are trying to integrate FSR3 to the project using sources from sdk/ folder. We are running on Windows/Linux using Vulkan.

After trying to destroy FSR3 Context I had a crash in ffxFsr3ContextDestroy. From my investigation it was happening due to double freeing of backend interface which is trying to be used in ffxFsr3UpscalerContextDestroy.

Commenting out contextPrivate->backendInterfaceSharedResources.fpDestroyBackendContext(&contextPrivate->backendInterfaceSharedResources, contextPrivate->effectContextIdSharedResources); fix the issue

svatostop avatar Nov 21 '24 16:11 svatostop

I run in a similar problem in ffx_frameinterpolation.cpp At line 995 and 1002 FFX_FRAMEINTERPOLATION_RESOURCE_IDENTIFIER_PRESENT_BACKBUFFER is registered as dynamic resource, but in frameinterpolationRelease is not unregisted from the "resources not created internally" Adding

context->srvResources[FFX_FRAMEINTERPOLATION_RESOURCE_IDENTIFIER_PRESENT_BACKBUFFER ]                      = {FFX_FRAMEINTERPOLATION_RESOURCE_IDENTIFIER_NULL};

at line 553 fixes the problem.

VeganPower avatar Jan 13 '25 17:01 VeganPower