Cauldron icon indicating copy to clipboard operation
Cauldron copied to clipboard

Published 20 hours ago • verified publisher icon GPUOpen-LibrariesAndSDKs

Tonemappers 'abs' are useless

Open GregSlazinski opened this issue 3 years ago • 0 comments

https://github.com/GPUOpen-LibrariesAndSDKs/Cauldron/blob/master/src/DX12/shaders/Tonemappers.hlsl#L75 https://github.com/GPUOpen-LibrariesAndSDKs/Cauldron/blob/master/src/DX12/shaders/Tonemappers.hlsl#L77

There are 2 abs, which I believe are useless since ratio should always be in 0..1 as long as colors are >=0

GregSlazinski avatar Sep 06 '21 03:09 GregSlazinski