Missing 'defined' in preprocessor check

Open BtbN opened this issue 3 years ago • 4 comments

The following line appears to be missing the 'defined', causing a compile time warning, and potentially some issue when actually using clang on non-linux.

https://github.com/GPUOpen-LibrariesAndSDKs/AMF/blob/9c7189ebb0a78e7e9287547b7898995abf268af8/amf/public/include/core/Platform.h#L75

Jul 17 '22 22:07 BtbN

Thanks for noticing this! It has been fixed and will be available in an upcoming release.

Jul 18 '22 18:07 rhutsAMD

Looking at that code some more, I do wonder if it's even correct at all? Like, Visual Studio does come with clang these days, and will certainly have HRESULT and friends defined.

Jul 18 '22 19:07 BtbN

Yes, it has been corrected to defined(__ANDROID__).

Jul 25 '22 17:07 rhutsAMD

The fix is now available in the latest release v1.4.26

Jul 27 '22 14:07 rhutsAMD