FidelityFX-FSR2 icon indicating copy to clipboard operation
FidelityFX-FSR2 copied to clipboard

patchResourceBindings can silently fail.

Open sagaceilo opened this issue 2 years ago • 0 comments

This code: https://github.com/GPUOpen-Effects/FidelityFX-FSR2/blob/e812d9e4c439106e88a6f7d40ca6fef3e88fef6d/src/ffx-fsr2-api/ffx_fsr2.cpp#L420

Should be wrapped with FFX_VALIDATE. In case some binding are not found FFX_ERROR_INVALID_ARGUMENT will be returned, but lib will leave this semi-filled pipeline and continue and return FFX_OK on exit. It should pass error code immediately imho.

sagaceilo avatar Feb 22 '23 09:02 sagaceilo