FidelityFX-FSR-Unity-URP icon indicating copy to clipboard operation
FidelityFX-FSR-Unity-URP copied to clipboard

Ported the URP 10.6.0 patch over to URP 12.1.4

Open OBXS opened this issue 2 years ago • 5 comments

Tested working on Unity 2021.2.13, but should work on Unity 2021.2.9 ~ 13

Edit: I just noticed that the Sample Bias variant on SurfaceInput.hlsl will never be called because ① the Lit.shader that uses SurfaceInput.hlsl doesn't set "_AMD_FSR" as keyword (#pragma multi_compile), and it's never set to be enabled in C#. ② "amd_fsr_mipmap_bias" is never defined as a variable in the shader.

Both of these also appears to be the case for the 10.6.0 patch, was this intentional?

OBXS avatar Mar 10 '22 07:03 OBXS

@OBXS When applying this patch - I get the following error: error: corrupt patch at line 142

Unity 2021.2.9f1

abhiavana avatar Jun 11 '22 10:06 abhiavana

Huh, that's interesting, I've made sure it worked when I commited it :/ I'll look into it when I have the time. (FSR 2.0's just around the horizon though so no promises)

OBXS avatar Jun 20 '22 15:06 OBXS

@OBXS When applying this patch - I get the following error: error: corrupt patch at line 142

Unity 2021.2.9f1

Same issue here, did you ever get it working?

ROBYER1 avatar Aug 03 '22 13:08 ROBYER1

Hi. i did follow the following steps without luck:

  1. I download the zip file, and extracted from it the FSR1.0-For-URP10.6.0-Patch.patch file.
  2. copy the patch file in the C:\urp_test_git\fsr_test\Library\PackageCache directory (i'm not sure if this step is correct)
  3. open on C:\urp_test_git\fsr_test\Library\PackageCache directory a git bash console, and did run the command: git apply FSR1.0-For-URP10.6.0-Patch.patch
  4. the git console dont show me any message, and when i open the project on unity editor i can't find the option to activate fsr on the camera settings ¿ any idea ?

Thanks.

alexArayaYahoo avatar Oct 05 '22 16:10 alexArayaYahoo

@OBXS would you recommend ditching this version and exploring how to incorporate v2 into our URP project?

rocco-haro avatar Jan 18 '23 00:01 rocco-haro