RayTracingInVulkan icon indicating copy to clipboard operation
RayTracingInVulkan copied to clipboard

CMake: Add install rule

Open xantares opened this issue 3 years ago • 2 comments

xantares avatar Nov 17 '21 18:11 xantares

ping @GPSnoopy

xantares avatar Feb 19 '22 11:02 xantares

Hi @xantares,

I have to admit that I have little experience with the install CMake command. So a few questions so I can understand this PR better:

  • Where does it install by default (on Windows and Linux)?
  • Are the assets also copied correctly to the right location?
  • If not, what is the value of the install rule as opposed to running the binary from the cmake-build/bin directory?
    • IMHO such rules make sense if you can run the raytracer from the command line from any working directory, but I'm unconvinced that the executable would correctly locate its assets without changing the source code.

Cheers, Tanguy

GPSnoopy avatar Feb 19 '22 11:02 GPSnoopy