gns3-registry icon indicating copy to clipboard operation
gns3-registry copied to clipboard

Add a field about the type of access to an appliance

Open julien-duponchelle opened this issue 9 years ago • 21 comments

A field with the information:

  • this appliance is free to download
  • this appliance require a free user account
  • this appliance require a trial key
  • this appliance require a paid support

I don't know how exactly we should call this field but in order to improve the marketplace on gns3.com ( https://gns3.com/discussions/request-for-organizing-the-appli) or the appliance wizard.

julien-duponchelle avatar Oct 24 '16 07:10 julien-duponchelle

I'd avoid "license" as it might lead to confusions. How about "availability" or "image-availability"?

adosztal avatar Oct 24 '16 17:10 adosztal

Availability sound like a good idea.

julien-duponchelle avatar Oct 25 '16 07:10 julien-duponchelle

Something like this?

    "availability": {
      "enum": ["free", "with-registration", "free-to-try", "service-contract"],
      "title": "About image availability: can be downloaded directly; download requires a free registration; paid but a trial version (time or feature limited) is available; not available publicly"
    },

adosztal avatar Oct 26 '16 04:10 adosztal

Seem good. What do you think @grossmj ?

julien-duponchelle avatar Oct 26 '16 07:10 julien-duponchelle

After agreeing on the format, I can make a branch for the updated appliance.json and .gns3a files.

adosztal avatar Oct 26 '16 09:10 adosztal

Here's the suggested solution: https://github.com/adosztal/gns3-registry/commit/2d8c1d4f47ff4e2e384a04761947f0f1340456e3 Keep it / change it / drop it?

adosztal avatar Oct 27 '16 10:10 adosztal

I just revert the merge because it's break current GNS3 release: error1

I need to check how we can relax that

julien-duponchelle avatar Oct 27 '16 15:10 julien-duponchelle

For me it's sound good and if we want to change we can script the modification.

On Thu, Oct 27, 2016 at 12:06 PM Andras Dosztal [email protected] wrote:

Here's the suggested solution: adosztal@2d8c1d4 https://github.com/adosztal/gns3-registry/commit/2d8c1d4f47ff4e2e384a04761947f0f1340456e3 Keep it / change it / drop it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GNS3/gns3-registry/issues/165#issuecomment-256600987, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVFXWsvmUnOtUYa79wrbtkbYLoy-9HPks5q4HeigaJpZM4KedCe .

julien-duponchelle avatar Oct 27 '16 15:10 julien-duponchelle

This is good, let's use availability.

On Tue, Oct 25, 2016, 23:23 Andras Dosztal [email protected] wrote:

After agreeing on the format, I can make a branch for the updated appliance.json and .gns3a files.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/GNS3/gns3-registry/issues/165#issuecomment-256294433, or mute the thread https://github.com/notifications/unsubscribe-auth/AEiE5vpLY0D4ANt9biIEzUB9IYix4dj2ks5q3xwDgaJpZM4KedCe .

grossmj avatar Oct 27 '16 15:10 grossmj

@noplay, what if I

  • revert my master branch too;
  • create a PR for my "availability" branch;
  • keep the version updates synchronized between the two branches?

This way you can merge the "availability" branch at a time convenient for you, after fixing the current release.

adosztal avatar Oct 27 '16 15:10 adosztal

Sound good to me

julien-duponchelle avatar Oct 27 '16 15:10 julien-duponchelle

Done. Btw, I scripted the modification with this small one. :)

adosztal avatar Oct 27 '16 16:10 adosztal

Need to wait 1.5.3 before changing appliances files

julien-duponchelle avatar Oct 28 '16 13:10 julien-duponchelle

That branch conflict appears every time I start committing changes to both. I'll keep the registry v4 files on a local drive; please drop a message here when I can commit them to my master branch, then I'll make the PR. You can delete this one too.

adosztal avatar Nov 04 '16 15:11 adosztal

I move this to 2.1 because for the moment we need to wait everyone upgrade to compatible client before changing that

julien-duponchelle avatar Nov 17 '16 09:11 julien-duponchelle

No problem, I'll keep the files updated.

adosztal avatar Nov 17 '16 10:11 adosztal

Thanks a lot for the help

julien-duponchelle avatar Nov 17 '16 12:11 julien-duponchelle

Ok 1.5.3 is shipped we can change the registry now

julien-duponchelle avatar Jan 24 '17 09:01 julien-duponchelle

1.5 still create trouble with that... Until user migrate to 2.0 we can't modify the appliances ....

julien-duponchelle avatar May 19 '17 06:05 julien-duponchelle

We will update the appliance files once we release version GNS3 version 2.2

grossmj avatar Jan 31 '18 12:01 grossmj

Ping me before the release and I'll update every appliance.

adosztal avatar Mar 03 '18 14:03 adosztal

This has been implement a while ago ;)

grossmj avatar Jan 30 '23 02:01 grossmj