vcf-js icon indicating copy to clipboard operation
vcf-js copied to clipboard

Use private fields for Variant class

Open cmdcolin opened this issue 1 year ago • 5 comments

Private class fields are natively supported on nodejs v12+

Previously we were transpiling down to es5 to maintain nodejs compatibility, but es5 could not have private class fields transpiled down. But, in this PR, I propose --module commonjs instead of --target es5 for nodejs compatibility

There are a couple other small refactors but that is the main one

Possibly having less transpilation could improve some performance under node in e.g. vcf-bench. Not an urgent PR, just an idea

cmdcolin avatar Aug 22 '22 20:08 cmdcolin