jbrowse icon indicating copy to clipboard operation
jbrowse copied to clipboard

Add saving cookies on loading/republishing tracks

Open cmdcolin opened this issue 5 years ago • 4 comments

This PR attempts to allow the user to save configuration changes across refreshes by storing configs in localStorage. It hooks into jbrowse at a low level and can save edits made via "Edit config" and when the "track replace" publish event is sent. Not all configuration changes use the publish event system though, for example displayMode. However, that could probably be remedied.

Feel free to provide feedback

cmdcolin avatar Nov 29 '18 15:11 cmdcolin

I forget, did we all talk about this? Any downsides to merging it?

rbuels avatar Dec 26 '18 14:12 rbuels

Basically the discussion was that a user could potentially get confused by their own track customizations and forget what defaults are, or if the server side config changed, the users settings still completely replace it (the settings are not merged), and there was no UI indication that a custom track config was being used or to a button to reset it.

cmdcolin avatar Dec 26 '18 16:12 cmdcolin

This also affects simply navigating to different chromosomes too, track settings are refreshed after navigating to different chromosomes without storing settings in localStorage

cmdcolin avatar Jun 20 '19 15:06 cmdcolin

I agree that users potentially will get confused when track customizations will persist even after refresh. I agree that this could be solved by a UI indication asking if the user wants to load their track costomizations. Or for example the ability to download your customizations to a file and load them when you reload your genome.

bejo-dionnez avatar Jun 21 '19 11:06 bejo-dionnez