jbrowse-components icon indicating copy to clipboard operation
jbrowse-components copied to clipboard

Circular dependencies in jbrowse/core

Open cmdcolin opened this issue 1 year ago • 0 comments

these cause bundler warnings and not good practice

rollup produces two errors from jbrowse/core

!) Circular dependencies
../node_modules/@jbrowse/core/ui/Dialog.js -> ../node_modules/@jbrowse/core/ui/ErrorMessage.js -> ../node_modules/@jbrowse/core/ui/ErrorMessageStackTraceDialog.js -> ../node_modules/@jbrowse/core/ui/Dialog.js

../node_modules/@jbrowse/core/BaseFeatureWidget/BaseFeatureDetail/Attributes.js -> ../node_modules/@jbrowse/core/BaseFeatureWidget/BaseFeatureDetail/ArrayValue.js -> ../node_modules/@jbrowse/core/BaseFeatureWidget/BaseFeatureDetail/Attributes.js

resolving circular dependencies sometimes involves putting a bunch of stuff in one file instead of different files, but there are also other techniques

cmdcolin avatar Feb 23 '24 20:02 cmdcolin