jbrowse-components
jbrowse-components copied to clipboard
GMOD
Initialize @jbrowse/app-core to share code between desktop/web/embedded
This starts out a new package called @jbrowse/app-core. This first example adds "createInternetAccount/findInternetAccount" authentications to the root model
Xref https://github.com/mobxjs/mobx-state-tree/discussions/1842#discussioncomment-1972622
currently there is internet-account specific autorun that is created in the web/desktop root models instead of in app-core since it's hard to create extra tasks for afterCreate, but that could be remedied probably
Could extension points be used for afterCreate?
On Wed, Sep 21, 2022 at 9:52 AM Colin Diesh @.***> wrote:
This starts out a new package called @jbrowse/app-core. This first example adds "createInternetAccount/findInternetAccount" authentications to the root model
Xref mobxjs/mobx-state-tree#1842 (comment) https://github.com/mobxjs/mobx-state-tree/discussions/1842#discussioncomment-1972622
currently there is internet-account specific autorun that is created in the web/desktop root models instead of in app-core since it's hard to create extra tasks for afterCreate, but that could be remedied probably
You can view, comment on, or merge this pull request online at:
https://github.com/GMOD/jbrowse-components/pull/3206 Commit Summary
- 8226f21 https://github.com/GMOD/jbrowse-components/pull/3206/commits/8226f21e04c4ea6ae002319d2ee1e897473e48f5 Start app-core
- 9d2345b https://github.com/GMOD/jbrowse-components/pull/3206/commits/9d2345bfe85fe132c2183e659bc47c2fffe87e14 Start app-core
- fb533a1 https://github.com/GMOD/jbrowse-components/pull/3206/commits/fb533a1655936ab31aa79bfb2fde17a8d953fb5a Don't use flat package layout
- eaaaf6b https://github.com/GMOD/jbrowse-components/pull/3206/commits/eaaaf6b62b6cf24f598384db262bd438f5253d42 Add tsconfigs
File Changes
(10 files https://github.com/GMOD/jbrowse-components/pull/3206/files)
- A packages/app-core/package.json https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-2a937954efefc822750175ecb568de61a16fdc2afd2ff61942c5610a0b3bb4bc (55)
- A packages/app-core/src/authenticationModel.ts https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-9d098c2aa8dd621d7b77b5a59e9cf61cd2df8659969eca4efc36f5979521b781 (99)
- A packages/app-core/src/index.ts https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-fb6009b1eeea738674a7f63756c7fa78b91c088d85f20af37941d237fcc4e6e9 (3)
- A packages/app-core/tsconfig.build.es5.json https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-74e169080c93d9a2568e316fd01e3ce4513db5080f6d344a1eadfbeee2f3d56e (19)
- A packages/app-core/tsconfig.build.esm.json https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-c0247f15a0871bfccb9f8a60f6fb4adc0fc244522499060cdef6c75335ad8c55 (18)
- A packages/app-core/tsconfig.json https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-e54807c925f08a8f98e5a37c4ffa1c992bd66ad47c773815a172a8a7d8951698 (9)
- M products/jbrowse-desktop/package.json https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-61a30b9619765c6b4eabad9e767293c7a0a63cf77d66e68eba65ff9dedca62fe (1)
- M products/jbrowse-desktop/src/rootModel.ts https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-b311b3421d0f695029b4651067bf6ee90d57c3faacb691c8d704392be6864398 (102)
- M products/jbrowse-web/package.json https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-f1d261f6bb010ce285f2c2c8565c8599bf0abf6eaca8672779f80913911e85d1 (1)
- M products/jbrowse-web/src/rootModel.ts https://github.com/GMOD/jbrowse-components/pull/3206/files#diff-37c54790e7f32ece80db57d4889cf4df1174c3a310d2bfbf4f63eddabca942f7 (111)
Patch Links:
- https://github.com/GMOD/jbrowse-components/pull/3206.patch
- https://github.com/GMOD/jbrowse-components/pull/3206.diff
— Reply to this email directly, view it on GitHub https://github.com/GMOD/jbrowse-components/pull/3206, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASAFOKDMAKQIHTG5EXKHLV7M4NXANCNFSM6AAAAAAQSIKWHQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
