jbrowse-components icon indicating copy to clipboard operation
jbrowse-components copied to clipboard

In LGV import, update sequence when assembly is changed

Open garrettjstevens opened this issue 3 years ago • 4 comments

Fixes #3126

garrettjstevens avatar Aug 11 '22 23:08 garrettjstevens

Codecov Report

Merging #3133 (782d7e7) into main (ad9bf14) will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   58.81%   58.79%   -0.03%     
==========================================
  Files         648      648              
  Lines       29042    29043       +1     
  Branches     7067     7067              
==========================================
- Hits        17082    17075       -7     
- Misses      11581    11589       +8     
  Partials      379      379              
Impacted Files Coverage Δ
...iew/src/LinearGenomeView/components/ImportForm.tsx 77.33% <0.00%> (-1.05%) :arrow_down:
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) :arrow_down:
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 80.55% <0.00%> (-5.56%) :arrow_down:
...gins/svg/src/SvgFeatureRenderer/components/util.ts 91.83% <0.00%> (-4.09%) :arrow_down:
...FeatureRenderer/components/ProcessedTranscript.tsx 87.32% <0.00%> (-1.41%) :arrow_down:
packages/core/util/layouts/GranularRectLayout.ts 86.86% <0.00%> (-0.43%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 11 '22 23:08 codecov[bot]

thanks for checking this out. I tried changing hg19 -> chm13 in https://jbrowse.org/code/jb2/3126-lgv-search-box-not-updating-on-genome-change/?config=test_data%2Fconfig_demo.json&session=share-l7F3ZDWWCL&password=58PjL but it did not seem to update the text field from 1 to chr1 (which chm13 uses)

cmdcolin avatar Aug 13 '22 03:08 cmdcolin

@cmdcolin that's odd, it works on a development build of this branch, but not in the deployed version. I'll have to look into that. Thanks for noticing.

garrettjstevens avatar Aug 15 '22 16:08 garrettjstevens

It seems to be something unique to the session @cmdcolin shared above. If I open that shared session, it doesn't work, but then if I refresh the page it does work, even though if I export the session it's exactly the same. I also can't reproduce the non-working version any way I try except for clicking on that shared session link. Even if I re-share the shared session without changing anything, it still works.

garrettjstevens avatar Aug 15 '22 20:08 garrettjstevens

maybe if we see the issue continue we can add another fix, this seems to fix it. even the link i said didn't work above maybe now works for me

cmdcolin avatar Aug 19 '22 19:08 cmdcolin

can merge for now

cmdcolin avatar Aug 19 '22 19:08 cmdcolin