jbrowse-components icon indicating copy to clipboard operation
jbrowse-components copied to clipboard

Extend theme with module augmentation

Open garrettjstevens opened this issue 3 years ago • 1 comments

This uses module augmentation to add the tertiary, quaternary, and base colors to our theme in TypeScript. This way, we can get rid of the @ts-ignores that are used whenever the tertiary, quaternary, or base colors are referenced.

garrettjstevens avatar Aug 11 '22 16:08 garrettjstevens

Codecov Report

Merging #3132 (984fe33) into main (ad9bf14) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
- Coverage   58.81%   58.79%   -0.03%     
==========================================
  Files         648      648              
  Lines       29042    29042              
  Branches     7067     7067              
==========================================
- Hits        17082    17075       -7     
- Misses      11581    11588       +7     
  Partials      379      379              
Impacted Files Coverage Δ
packages/core/ui/theme.ts 83.33% <ø> (ø)
...s/alignments/src/PileupRenderer/PileupRenderer.tsx 50.40% <ø> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 73.38% <ø> (ø)
...r-view/src/BaseChordDisplay/components/Loading.tsx 92.85% <ø> (ø)
...ierarchicalTrackSelectorWidget/components/Node.tsx 61.90% <ø> (ø)
...PluginStoreWidget/components/PluginStoreWidget.tsx 77.77% <ø> (ø)
...t/src/JobsListWidget/components/JobsListWidget.tsx 5.88% <ø> (ø)
...c/LinearGenomeView/components/OverviewScaleBar.tsx 64.51% <ø> (ø)
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) :arrow_down:
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 80.55% <0.00%> (-5.56%) :arrow_down:
... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 11 '22 19:08 codecov[bot]

looks good :)

cmdcolin avatar Aug 19 '22 20:08 cmdcolin