jbrowse-components icon indicating copy to clipboard operation
jbrowse-components copied to clipboard

Update existing config.jsons with COSMIC connections with new URL

Open carolinebridge opened this issue 2 years ago • 2 comments

update dataDirLocation uri to https://cancer.sanger.ac.uk/jbrowse/data/json/grch38/v96/gene (/tracklist.json)

Potentially also have to update the config load parser to be looser with JSON restrictions, currently getting an error:

Error: SyntaxError: Unexpected token / in JSON at position 13437 when parsing configuration.

carolinebridge avatar Jun 07 '22 23:06 carolinebridge

We may want to remove the COSMIC connection from test_data/config.json, it does not work on web (CORS). Could potentially be on desktop only, deployed with products/jbrowse-predefined-sessions

cmdcolin avatar Jun 13 '22 16:06 cmdcolin

the fact that this URL moves around is a bit concerning for maintainability though, and could be considered to remove entirely also

cmdcolin avatar Jun 13 '22 16:06 cmdcolin

I went ahead and removed them for now, could do further stuff in https://github.com/GMOD/jbrowse-components/issues/2304

cmdcolin avatar Sep 29 '22 23:09 cmdcolin