cram-js icon indicating copy to clipboard operation
cram-js copied to clipboard

Ensure compatibility with CRAM 3.1 files

Open cmdcolin opened this issue 1 year ago • 1 comments

samtools announced that their current version is the last version that will only output CRAM 3.0, next versions will be CRAM 3.1. We should test that we can accomodate 3.1 files

See "This is the last SAMtools / HTSlib release where CRAM 3.0 will be the default CRAM version. From the next we will change to CRAM 3.1 unless the version is explicitly specified, for example using samtools view -O cram,version=3.0." https://github.com/samtools/samtools/releases/tag/1.21

cmdcolin avatar Sep 25 '24 22:09 cmdcolin

initial testing found at least one possible fail, possible patch with htscodecs PR here https://github.com/jkbonfield/htscodecs/pull/1

cmdcolin avatar Sep 26 '24 16:09 cmdcolin

cc @jrobinso there was a fix for some CRAM 3.1 files in new cram-js release v3.0.7.

at least one file from the hts-specs test ("level4.cram") was failing in previous cram-js versions (https://github.com/samtools/hts-specs/tree/master/test/cram/3.1/passed)

i wanted to make sure cram 3.1 was supported since samtools release docs said they're making it on by default soon "https://github.com/samtools/samtools/releases"

cmdcolin avatar Nov 08 '24 15:11 cmdcolin

fixed by this PR https://github.com/GMOD/cram-js/pull/144

cmdcolin avatar Nov 08 '24 15:11 cmdcolin

Thanks for the heads up!

On Fri, Nov 8, 2024 at 10:18 AM Colin Diesh @.***> wrote:

fixed by this PR #144 https://github.com/GMOD/cram-js/pull/144

— Reply to this email directly, view it on GitHub https://github.com/GMOD/cram-js/issues/141#issuecomment-2465015827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHD2HAURCO6VRXRXXQ27P3Z7TI2ZAVCNFSM6AAAAABO3SNWNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGAYTKOBSG4 . You are receiving this because you were mentioned.Message ID: @.***>

jrobinso avatar Nov 08 '24 17:11 jrobinso