HELICS icon indicating copy to clipboard operation
HELICS copied to clipboard

log should use federate name or core name instead of internal identifier

Open kdheepak opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe.

Currently, console logs print warnings such as the following:

[2021-03-06 15:28:11.175] [console] [warning] commWarning||7896-s5pfY-x4yYC-aBAXB-PmbYX (1)::unknown route and no broker, dropping message pub:From (131072) handle(1) size 2949 at 60.0 to 131073

It is not straightforward to find what is 131073 is without scrolling to the history of the console log output. This is a pain point when the log consists of a lot of other data.

Describe the solution you'd like

I would prefer a log that showed the following information

[2021-03-06 15:28:11.175] [console] [warning] commWarning||7896-s5pfY-x4yYC-aBAXB-PmbYX (1)::unknown route and no broker, dropping message pub:From (131072) handle(1) size 2949 at 60.0 to UserProvidedNameForFederateA

kdheepak avatar Mar 06 '21 22:03 kdheepak

I think the logs have been tweaks to show better information, so I am going to close this, if you have other suggestions lets open a new issue.

phlptp avatar Jun 16 '22 18:06 phlptp

Here are examples from a recent trace logging where the internal identifiers (131702, 131703) are used. With some effort its possible for users to figure out which number corresponds to which federate (at least for small federations) but it would greatly increase the utility of the logging if names could be used.

[2022-06-28 13:55:14.336] [console] [trace] Charger (1879048193)[t=604800]::|| cmd:pub:From (131073) handle(7) size 16 at 604800 to 131072 from 131073

trevorhardy avatar Jun 28 '22 21:06 trevorhardy