NPB-GPU icon indicating copy to clipboard operation
NPB-GPU copied to clipboard

IS updates

Open zjin-lcf opened this issue 4 years ago • 9 comments

Hi

I built and ran the IS program for the class D problem size, but the verification fails. It is quite fast to run the programs with smaller problem sizes on a p100 gpu. Thank you for your updates.

zjin-lcf avatar Aug 30 '21 03:08 zjin-lcf

Hello.

The verification routine is failing because an overflow error is occurring with class D (int type is not large enough for this class).

We will fix it as soon as possible.

Thank you for using the NPB-GPU, and thank you for reporting this bug.

gabriellaraujocoding avatar Sep 28 '21 13:09 gabriellaraujocoding

Thank you for explaining the error.

zjin-lcf avatar Sep 28 '21 13:09 zjin-lcf

Is there a upper bound to the value of MAX_ITERATION ? The default value is 10.

zjin-lcf avatar Oct 25 '21 03:10 zjin-lcf

Hello.

Yes, in the practice, there is an upper bound. However, the NPB documentation does not explain which is the maximum amount of iterations supported (it may vary according to the hardware).

Our implementation followed the original NPB version, and the default value of MAX_ITERATIONS set by NASA is 10.

On my machine, I tested other values, and the benchmark worked with up to 24 iterations. With an amount of iterations larger than 24, the IS benchmark started failing in the correctness verification, even when using long int type.

gabriellaraujocoding avatar Nov 18 '21 17:11 gabriellaraujocoding

Using long int type implies the class D problem. Have you updated your program to support the class D problem ?

Thanks

zjin-lcf avatar Nov 18 '21 18:11 zjin-lcf

We haven't had time to fix this issue yet.

gabriellaraujocoding avatar Nov 18 '21 18:11 gabriellaraujocoding

Hello.

We fixed the IS benchmark issue with class D.

However, class D consumes about 19 gigabytes of GPU memory. Thus, a GPU needs at least 19 gigabytes of memory to work correctly with this workload.

gabriellaraujocoding avatar Dec 02 '22 15:12 gabriellaraujocoding

A memory check may be added to the CUDA program so that the test is skipped without enough memory. Thanks.

zjin-lcf avatar Dec 02 '22 15:12 zjin-lcf

A memory check may be added to the CUDA program so that the test is skipped without enough memory. Thanks.

It is a good suggestion. We will add this feature soon.

gabriellaraujocoding avatar Dec 06 '22 18:12 gabriellaraujocoding