Giampiero

Results 25 comments of Giampiero

### Detailed description (https://github.com/aussig/BGS-Tally/pull/324/commits/cd30bd24b9a9298cece199762658c6a3c4616447) - **Refactor of the `__` translation function:** - The function now handles more robustly the cases where the requested language is empty (`""`), `None` or matches...

Before closing the PR I would like to discuss the control of the pre 5.0.0 version. _get_edmc_version() ```py def _get_edmc_version(appversion) -> semantic_version.Version: """ Return the EDNC version as a semantic_version.Version...

At this point, the `edmc_version` variable is assigned by the `appversion()` function (https://github.com/aussig/BGS-Tally/pull/324/commits/03152614842aa050b24a29b5967b240b6c8058f1). - Simplifying the structure and logic. If for you @aussig there are no further points to validate,...

### Missing `"en.strings"` file causes fallback to fail, raising `KeyError` --- **Description:** When the localisation system is asked to translate using `lang="en"` but no `en.strings` file is present in the...

I will send a copy by the weekend