oshdb icon indicating copy to clipboard operation
oshdb copied to clipboard

Improve documentation of MapReducer's timestamp setter

Open SlowMo24 opened this issue 4 years ago • 6 comments

We implement our own ISO 8601 String parser (is there really no default parser out there?). When supplying a Date this is transformed to a Timestamp https://github.com/GIScience/oshdb/blob/eac6d34ac893615c65fe3f30a389f70681c74e33/oshdb-util/src/main/java/org/heigit/bigspatialdata/oshdb/util/time/ISODateTimeParser.java#L59 using the 'start of the day' i.e. ...T00:00:00Z

This should be documented in https://github.com/GIScience/oshdb/blob/3b46a1390e33d920d9ed9eddabed56a661997d9e/oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/MapReducer.java#L303-L316

SlowMo24 avatar Oct 29 '20 18:10 SlowMo24

fix when addressing #169 , also related: #259 et al

SlowMo24 avatar Oct 30 '20 09:10 SlowMo24

How else did you expect the transformation to be done if the time part of a date-time string was not provided? Noon (12:00:00) or end of day (23:59:59)?

tyrasd avatar Nov 03 '20 17:11 tyrasd

I had no expectation to the implementation (although date] and date[ seem equal opponents and I prefer the current implementation) but rather to the documentation ;-)

SlowMo24 avatar Nov 03 '20 18:11 SlowMo24

ok. It's about improving the documentation… I changed the title of the ticket accordingly.

tyrasd avatar Nov 04 '20 08:11 tyrasd

sorry, misclick

tyrasd avatar Nov 04 '20 09:11 tyrasd

@tyrasd will work on this.

Hagellach37 avatar Oct 20 '22 13:10 Hagellach37