openrouteservice-examples icon indicating copy to clipboard operation
openrouteservice-examples copied to clipboard

MM_avoid_noisy_areas_NY

Open MichaelMoyles opened this issue 1 year ago • 3 comments

This notebook demonstrates the merging of overlapping polygons prior to an API call to the ORS server. The purpose of the application is to route users around noisy areas.

Combining overlapping polygons reduces API calls and improves performance for data similar to the noise data used, where data points are clustered in particular areas.

MichaelMoyles avatar Oct 16 '23 14:10 MichaelMoyles

@MichaelMoyles Hi, and a big :heart: for your contribution. Nice! We'll have a look at it in time and get back to you.

MichaelsJP avatar Oct 19 '23 11:10 MichaelsJP

Hi @MichaelMoyles, looks very nice! Thanks again for contributing!

I just have some small change requests:

  1. Please try to reduce the size of the data set as much as possible, so ideally around 1MB.
  2. Please pair the notebook with a lightweight python file as described in the readme and push it to github.
  3. Feel free to add your name at the top of the notebook as author if you like.

Regarding the maps:

  1. You might want to choose a different base map or change the colour of the noise polygons on the map, because they are hard to see.
  2. And one tip: geopandas now offers the gdf.explore() function which makes creating interactive maps a lot easier with less code. You might want to check whether you can reduce some of the code in this way. Also changing the basemap is very easy.

redfrexx avatar Nov 02 '23 11:11 redfrexx

Thanks for the requests @redfrexx

  1. I have reduced the size of the dataset to under 1MB
  2. I have paired the notebook with a python file
  3. Have added my name to the files

For the maps, I have changed the colours of the polygons to make them easier to see and have reduced a lot of the code from using geopandas, thanks for the suggestion there!

MichaelMoyles avatar Nov 19 '23 14:11 MichaelMoyles