Ghpr.Core icon indicating copy to clipboard operation
Ghpr.Core copied to clipboard

Published 20 hours ago • verified publisher icon GHPReporter

Retention "till"

Open TFiFiE opened this issue 5 years ago • 1 comments

The till setting is misleadingly named, because being under retention, it would imply that test runs up to the given time are retained rather than deleted or that test runs are kept until that point in time is reached. since (or similar) would be a much more logical choice and would also be consistent with amount by having the phrasing be in terms of what is kept. Examples where this has tripped up people: https://github.com/GHPReporter/Ghpr.MSTest/issues/23#issue-463922229 https://github.com/GHPReporter/Ghpr.Console/issues/43#issue-489186532

TFiFiE avatar Jan 10 '20 22:01 TFiFiE

Thank you for the issue!

I agree this makes sense, going to fix the naming. The since name looks like a good one.

elv1s42 avatar Mar 18 '20 15:03 elv1s42