torchgfn icon indicating copy to clipboard operation
torchgfn copied to clipboard

Published 20 hours ago • verified publisher icon GFNOrg

improve box_utils.py file

Open saleml opened this issue 1 year ago • 0 comments

Copied from https://github.com/saleml/torchgfn/pull/66

  • Simplify the code. I don't think we need the BoxPFEstimator and BoxPFNeuralNet to be two distinct classes. It would be easier if all the logical existed in the BoxPFEstimator. But we can debate this.
  • Ensure the Tabular case works as intended.
  • Put the tests in a proper place. But where?

saleml avatar Jun 21 '23 20:06 saleml