torchgfn icon indicating copy to clipboard operation
torchgfn copied to clipboard

Renaming `batch_dim`

Open josephdviviano opened this issue 1 year ago • 0 comments

Right now batch_dim actually has two, specific dimensions:

would it make more sense for the batch_dim[0] to be named batch_dim and batch_dim[1] to be named trajectory_dim or something (since I assume that’s what these two batch dimensions will always be used for?)

Definitely, that’s always the case for trajectories. The first dimension is the maximum length of the trajectories. The second is the number of trajectories. How could we do the renaming ?

We need to explore how to implement this in the code, which would make everything much clearer to the user.

josephdviviano avatar Aug 02 '23 21:08 josephdviviano