GEOS
GEOS copied to clipboard
Consistent use of 'NodeManager' or `arrayView2d< real64 const, nodes::REFERENCE_POSITION_USD > const & X`
Some methods are using NodeManager
as input, some are using arrayView2d< real64 const, nodes::REFERENCE_POSITION_USD > const & X
e.g.
https://github.com/GEOSX/GEOSX/blob/b1224b9d6f190bb6f44025c687b3c46f18f36c28/src/coreComponents/mesh/FaceManager.hpp#L73-L79
We need to be coherent, I think for the user-developper, giving a NodeManager
is simpler.
Well SortFaceNodes
is called inside a forAll< paralleHostPolicy >
so I don't think we should be calling nodeManager->referencePosition
inside a loop. I would argue that since SortAllFaceNodes
only needs the reference position from the NodeManager
it's better to only pass that instead of giving the method access to the entire NodeManager
.
This is a legacy piece of code. It should be removed.