GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

feat: WaveEquation : new acoustic gradient formulation

Open rmadec-cs opened this issue 1 year ago • 1 comments

New Acoustic gradient formulation with respect to parameters Kappa=1/rho*c2 and Buoyancy=1/rho replacing old gradient formulation with respect to velocity c

rmadec-cs avatar Sep 20 '24 09:09 rmadec-cs

Codecov Report

Attention: Patch coverage is 77.00535% with 43 lines in your changes missing coverage. Please review.

Project coverage is 57.11%. Comparing base (dc6a6be) to head (d97241d). Report is 59 commits behind head on develop.

Files with missing lines Patch % Lines
...condOrderEqn/isotropic/AcousticWaveEquationSEM.cpp 23.52% 26 Missing :warning:
.../sem/acoustic/shared/AcousticMatricesSEMKernel.hpp 0.00% 17 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3361      +/-   ##
===========================================
+ Coverage    57.05%   57.11%   +0.06%     
===========================================
  Files         1150     1151       +1     
  Lines        99304    99454     +150     
===========================================
+ Hits         56660    56808     +148     
- Misses       42644    42646       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 20 '24 09:09 codecov[bot]

@acitrain @rrsettgast @CusiniM @wrtobin @corbett5 does any of you have time for a review of this PR? Thanks!

sframba avatar Dec 03 '24 08:12 sframba

Hi @rrsettgast,

Can you please final check this PR? Everything is good rebaseline included

Thank you !

acitrain avatar Dec 03 '24 15:12 acitrain

@rmadec-cs @acitrain baselines got updated under this. Gonna have to put baselines back to develop...run integratedTests again...then set the baseline to the new hash....but wait until you are first in line in the queue...otherwise you may have to do it again!

rrsettgast avatar Dec 04 '24 06:12 rrsettgast

@rmadec-cs @acitrain baselines got updated under this. Gonna have to put baselines back to develop...run integratedTests again...then set the baseline to the new hash....but wait until you are first in line in the queue...otherwise you may have to do it again!

done

paveltomin avatar Dec 04 '24 20:12 paveltomin

@paveltomin I took this out of the queue due to @CusiniM request.

rrsettgast avatar Dec 05 '24 01:12 rrsettgast