GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

Umpire logs refactor - table output + adding percentages

Open arng40 opened this issue 11 months ago • 1 comments

Update for memory statistics table :

What we currently have :

Umpire          DEVICE sum across ranks: 15293.4 GB
Umpire          DEVICE         rank max:   31.3 GB
Umpire       DEVICE::0 sum across ranks: 15293.4 G
Umpire       DEVICE::0         rank max:   31.3 GB
Umpire            HOST sum across ranks: 7272.2 GB
Umpire            HOST         rank max:   14.7 GB
Umpire HYPRE_DEVICE_POOL sum across ranks: 7178.4 GB
Umpire HYPRE_DEVICE_POOL         rank max:   14.8 GB
Umpire          PINNED sum across ranks:  256.3 GB
Umpire          PINNED         rank max:  589.6 MB

This is what I propose inspired by the display proposed by @victorapm

+-----------------------------+---------------------+---------------------+---------------------+--------------------+
|         Umpire Memory Pool  |     Min over ranks  |    Max  over ranks  |    Avg  over ranks  |    Sum over ranks  |
|  (reserved / % over total)  |                     |                     |                     |                    |
+-----------------------------+---------------------+---------------------+---------------------+--------------------+
|                     DEVICE  |    1.4 MB   (0.0%)  |    1.7 MB   (0.0%)  |    1.5 MB   (0.0%)  |   6.1 MB   (0.0%)  |
|                  DEVICE::0  |    1.4 MB   (0.0%)  |    1.7 MB   (0.0%)  |    1.5 MB   (0.0%)  |   6.1 MB   (0.0%)  |
|                       HOST  |    2.3 MB   (0.0%)  |    2.5 MB   (0.0%)  |    2.4 MB   (0.0%)  |   9.8 MB   (0.0%)  |
|              HYPRE_UM_POOL  |  504.7 KB   (0.0%)  |  645.8 KB   (0.0%)  |  542.4 KB   (0.0%)  |   2.1 MB   (0.0%)  |
|                     PINNED  |  488.1 KB   (0.0%)  |  963.0 KB   (0.0%)  |  725.5 KB   (0.0%)  |   2.8 MB   (0.0%)  |
|                         UM  |    4.0 GB  (25.3%)  |    4.0 GB  (25.3%)  |    4.0 GB  (25.3%)  |  16.0 GB  (25.3%)  |
+-----------------------------+---------------------+---------------------+---------------------+--------------------+

Code side

  • I've also refactored a bit the addUmpireHighWaterMarks() function to modern C++

arng40 avatar Mar 21 '24 15:03 arng40

Codecov Report

Attention: Patch coverage is 80.83141% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 53.40%. Comparing base (4696a65) to head (c9cf6be). Report is 3 commits behind head on develop.

Files Patch % Lines
src/coreComponents/fileIO/Table/TableFormatter.cpp 85.05% 26 Missing :warning:
...reComponents/mesh/generators/WellGeneratorBase.cpp 4.00% 24 Missing :warning:
src/coreComponents/common/MemoryInfos.cpp 56.52% 10 Missing :warning:
src/coreComponents/fileIO/Table/TableData.cpp 76.31% 9 Missing :warning:
src/coreComponents/common/DataTypes.hpp 0.00% 4 Missing :warning:
...rc/coreComponents/common/initializeEnvironment.cpp 87.87% 4 Missing :warning:
...oreComponents/fileIO/Table/unitTests/testTable.cpp 96.73% 3 Missing :warning:
src/coreComponents/fileIO/Table/TableLayout.cpp 92.00% 2 Missing :warning:
src/coreComponents/fileIO/Table/TableFormatter.hpp 66.66% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3052      +/-   ##
===========================================
+ Coverage    53.20%   53.40%   +0.19%     
===========================================
  Files          989      997       +8     
  Lines        83456    83953     +497     
===========================================
+ Hits         44405    44834     +429     
- Misses       39051    39119      +68     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 25 '24 10:03 codecov[bot]