GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

Fix unit tests on GPU CI platform.

Open rrsettgast opened this issue 1 year ago • 2 comments

unit tests are now being executed on a GPU enabled runner. Two tests are failing. I turned them off in develop and have reenabled them in this PR. They need to be fixed asap. Then we can move to the integratedTests on a GPU runner.

  • [x] Fix testLifoStorage @sframba If not you, then can you assign someone on your team?
  • [ ] Fix testExternalSolvers @castelletto1 @CusiniM

rrsettgast avatar Feb 09 '24 19:02 rrsettgast

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.14%. Comparing base (45725d5) to head (963780d).

:exclamation: Current head 963780d differs from pull request most recent head fb73463. Consider uploading reports for the commit fb73463 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2985      +/-   ##
===========================================
- Coverage    53.20%   52.14%   -1.07%     
===========================================
  Files          989      973      -16     
  Lines        83456    82483     -973     
===========================================
- Hits         44405    43010    -1395     
- Misses       39051    39473     +422     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 09 '24 21:02 codecov[bot]

@rrsettgast testLifoStorage should be ok now, @jiemeng-total pushed her fix into this branch

sframba avatar Apr 09 '24 15:04 sframba