GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

remove RESQML support from GEOS

Open untereiner opened this issue 1 year ago • 8 comments

Companion PR https://github.com/GEOS-DEV/thirdPartyLibs/pull/258

untereiner avatar Jan 31 '24 10:01 untereiner

@TotoGaz I don't know how to deal with the spack recipes. Should I remove them too ? They could be necessary for building geos with spack with the RESQML external component

untereiner avatar Jan 31 '24 10:01 untereiner

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3cdbde8) 51.36% compared to head (7132ce3) 51.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2969      +/-   ##
===========================================
- Coverage    51.36%   51.36%   -0.01%     
===========================================
  Files          972      972              
  Lines        86990    86990              
===========================================
- Hits         44683    44681       -2     
- Misses       42307    42309       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 31 '24 10:01 codecov[bot]

@untereiner I can remove them from spack if they are no longer being used.

bmhan12 avatar Jan 31 '24 16:01 bmhan12

That would be nice, thank you @bmhan12 @untereiner does it make sense to keep the spack recipe if we're not using/validating it anymore? Is the git history enough if we want to revive it?

TotoGaz avatar Jan 31 '24 16:01 TotoGaz

Thank you @bmhan12 ! If think the git history is enough. I am wondering how to play with these recipes with what I call an « external component » eg: added at compile time but in another repository

untereiner avatar Jan 31 '24 20:01 untereiner

I am wondering how to play with these recipes with what I call an « external component » eg: added at compile time but in another repository

You mean spack recipes? I've never been using spack so I do not know.

TotoGaz avatar Jan 31 '24 22:01 TotoGaz

Yes, I ment spack recipes.

untereiner avatar Jan 31 '24 22:01 untereiner

@TotoGaz This one should be easy

untereiner avatar Mar 11 '24 09:03 untereiner