GEOS
GEOS copied to clipboard
remove RESQML support from GEOS
Companion PR https://github.com/GEOS-DEV/thirdPartyLibs/pull/258
@TotoGaz I don't know how to deal with the spack recipes. Should I remove them too ? They could be necessary for building geos with spack with the RESQML external component
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3cdbde8
) 51.36% compared to head (7132ce3
) 51.36%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #2969 +/- ##
===========================================
- Coverage 51.36% 51.36% -0.01%
===========================================
Files 972 972
Lines 86990 86990
===========================================
- Hits 44683 44681 -2
- Misses 42307 42309 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@untereiner I can remove them from spack if they are no longer being used.
That would be nice, thank you @bmhan12
@untereiner does it make sense to keep the spack
recipe if we're not using/validating it anymore? Is the git
history enough if we want to revive it?
Thank you @bmhan12 ! If think the git history is enough. I am wondering how to play with these recipes with what I call an « external component » eg: added at compile time but in another repository
I am wondering how to play with these recipes with what I call an « external component » eg: added at compile time but in another repository
You mean spack
recipes? I've never been using spack
so I do not know.
Yes, I ment spack recipes.
@TotoGaz This one should be easy