Feature/byer3/mass inj const

[tjb-ltk]

Add support for mass injection well constraint Tested vol inj and equivalent mass inj table constraint and results are in agreement inputFiles/compositionalMultiphaseWell/benchmarks/Class09Pb3/class09_pb3_benchmark.xml inputFiles/compositionalMultiphaseWell/benchmarks/Class09Pb3/class09_pb3_benchmark_mct.xml

[paveltomin]

move to merge queue?

[tjb-ltk]

The baselines need updating, the restart tests fail because a new field was added .
When doing the baseline process steps 1-6... I get this error..Bad file: /usr/WS2/byer3/GEOS-DEV/mass_inj_const/integratedTests/tests/allTests/viscoPlastic/viscoPlastic.ats Its nothing I've changed.. need to show it to someone..

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 53.03030% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 53.72%. Comparing base (238b851) to head (7b3576a).

Files	Patch %	Lines
...dFlow/wells/CompositionalMultiphaseWellKernels.cpp	30.43%	16 Missing :warning:
...dFlow/wells/CompositionalMultiphaseWellKernels.hpp	0.00%	9 Missing :warning:
...ts/physicsSolvers/fluidFlow/wells/WellControls.cpp	75.00%	6 Missing :warning:

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2917   +/-   ##
========================================
  Coverage    53.72%   53.72%           
========================================
  Files          994      994           
  Lines        84687    84746   +59     
========================================
+ Hits         45499    45532   +33     
- Misses       39188    39214   +26     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[CusiniM]

The baselines need updating, the restart tests fail because a new field was added . When doing the baseline process steps 1-6... I get this error..Bad file: /usr/WS2/byer3/GEOS-DEV/mass_inj_const/integratedTests/tests/allTests/viscoPlastic/viscoPlastic.ats Its nothing I've changed.. need to show it to someone..

Let's have a look together at this.

[tjb-ltk]

I pushed the rebaseline to feature/byer3/mass_inj_const

[paveltomin]

merge queue?

[tjb-ltk]

still need to rebaseline for new keyword, the restart tests fail... is the rebaselining automated yet ?

[paveltomin]

still need to rebaseline for new keyword, the restart tests fail... is the rebaselining automated yet ?

i don't think the procedure has changed, but it does not make much sense to rebase before PR is not on top of the queue

[paveltomin]

@tjb-ltk @CusiniM can we merge this? it's something useful for users, worth merging imho

[tjb-ltk]

I’ll work with Mateo to get the baselines updated…. I’m consistently doing something wrong in steps 1-6…. Even having issues with thermal bug fix baseline updates..

From: Pavel Tomin @.> Reply-To: GEOS-DEV/GEOS @.> Date: Wednesday, April 24, 2024 at 8:36 AM To: GEOS-DEV/GEOS @.> Cc: "Byer, Thomas James" @.>, Mention @.***> Subject: Re: [GEOS-DEV/GEOS] Feature/byer3/mass inj const (PR #2917)

@tjb-ltkhttps://urldefense.us/v3/__https:/github.com/tjb-ltk__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKHjZ53h7$ @CusiniMhttps://urldefense.us/v3/__https:/github.com/CusiniM__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKBqZGCcP$ can we merge this? it's something useful for users, worth merging imho

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/GEOS-DEV/GEOS/pull/2917*issuecomment-2075237024__;Iw!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKLVEwEFJ$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/BDWKKI2JZMFTSPVCJBTMCALY67GQTAVCNFSM6AAAAABBEXKXMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGIZTOMBSGQ__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKFcSURnD$. You are receiving this because you were mentioned.Message ID: @.***>

[tjb-ltk]

I just committed the baseline updates to byer3/feature/mass_inj_const please merge this code….

From: Pavel Tomin @.> Reply-To: GEOS-DEV/GEOS @.> Date: Wednesday, April 24, 2024 at 8:36 AM To: GEOS-DEV/GEOS @.> Cc: "Byer, Thomas James" @.>, Mention @.***> Subject: Re: [GEOS-DEV/GEOS] Feature/byer3/mass inj const (PR #2917)

@tjb-ltkhttps://urldefense.us/v3/__https:/github.com/tjb-ltk__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKHjZ53h7$ @CusiniMhttps://urldefense.us/v3/__https:/github.com/CusiniM__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKBqZGCcP$ can we merge this? it's something useful for users, worth merging imho

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/GEOS-DEV/GEOS/pull/2917*issuecomment-2075237024__;Iw!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKLVEwEFJ$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/BDWKKI2JZMFTSPVCJBTMCALY67GQTAVCNFSM6AAAAABBEXKXMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGIZTOMBSGQ__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKFcSURnD$. You are receiving this because you were mentioned.Message ID: @.***>

[CusiniM]

I just committed the baseline updates to byer3/feature/mass_inj_const please merge this code…. From: Pavel Tomin @.> Reply-To: GEOS-DEV/GEOS @.> Date: Wednesday, April 24, 2024 at 8:36 AM To: GEOS-DEV/GEOS @.> Cc: "Byer, Thomas James" @.>, Mention @.> Subject: Re: [GEOS-DEV/GEOS] Feature/byer3/mass inj const (PR #2917) @tjb-ltkhttps://urldefense.us/v3/__https:/github.com/tjb-ltk__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKHjZ53h7$ @CusiniMhttps://urldefense.us/v3/__https:/github.com/CusiniM__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKBqZGCcP$ can we merge this? it's something useful for users, worth merging imho — Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/GEOS-DEV/GEOS/pull/2917*issuecomment-2075237024__;Iw!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKLVEwEFJ$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/BDWKKI2JZMFTSPVCJBTMCALY67GQTAVCNFSM6AAAAABBEXKXMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGIZTOMBSGQ__;!!G2kpM7uM-TzIFchu!3_63PqNOMY03rOl7dxHWlYRqrDxuqmjk1vuoA8xAUS5fJvXRFjOOBxrwYG2VQt74hpf5JnTgBGsMotWqKFcSURnD$. You are receiving this because you were mentioned.Message ID: @.>

I ll put the PR in the queue but you ll llikely need to update the baselines right before the merge.