GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

add flags to enable fesapi

Open untereiner opened this issue 2 years ago • 5 comments

created branch to add flags to enable fesapi from the third parties (related to #2109)

untereiner avatar Oct 10 '22 07:10 untereiner

@bmhan12 @wrtobin There needs to be some spack/uberenv work in conjunction with this?

rrsettgast avatar Oct 10 '22 17:10 rrsettgast

@rrsettgast I think Fesapi would need some spack work. Fesapi has zlib, minizip and boost (only headers) as dependencies. I checked that boost is already in spack and available as a header only dependency. It is exactly what fesapi needs. It would even be easier than with CMake's ExternalProject_Add function.

untereiner avatar Oct 12 '22 08:10 untereiner

@rrsettgast I think Fesapi would need some spack work. Fesapi has zlib, minizip and boost (only headers) as dependencies. I checked that boost is already in spack and available as a header only dependency. It is exactly what fesapi needs. It would even be easier than with CMake's ExternalProject_Add function.

But on the long term, what would be your exact requirements? Do you have a clear picture on this?

TotoGaz avatar Oct 12 '22 15:10 TotoGaz

We'll need to implement a spack package recipe for fesapi, but it can be done after the initial integration into GEOSX is complete IMO. For now, to avoid breaking spack build, I propose we modify it to explicitly disable fesapi (spit out ENABLE_FESAPI=OFF into the generated host-config).

klevzoff avatar Oct 12 '22 19:10 klevzoff

have

But on the long term, what would be your exact requirements? Do you have a clear picture on this?

In a first step for file based access:

  • hdf5 (default numerical values storage for RESQML)
  • minizip (in order to deal with zip files)
  • boost (only headers for having uuid support).

In a long-term view with connection to OSDU, it will be necessary to add:

  • FETPAPI
  • AVRO (for serialization and deserialization of message)
  • Boost (libraries, not only headers, mainly Beast sublibrary for websocket support)
  • OpenSSL (TLS support).

untereiner avatar Oct 13 '22 14:10 untereiner

I think it is good now @TotoGaz

untereiner avatar Nov 01 '22 22:11 untereiner

@TotoGaz Is it possible to merge both PRs in the next hours ?

untereiner avatar Nov 04 '22 09:11 untereiner

You are second in line https://github.com/GEOSX/GEOSX/projects/18

TotoGaz avatar Nov 04 '22 15:11 TotoGaz

You are second in line https://github.com/GEOSX/GEOSX/projects/18

ok, do you have any idea when it will happen ?

untereiner avatar Nov 07 '22 14:11 untereiner

ok, do you have any idea when it will happen ?

@rrsettgast is going to give https://github.com/GEOSX/GEOSX/pull/2149 a last view.

TotoGaz avatar Nov 07 '22 17:11 TotoGaz