GEOS
GEOS copied to clipboard
[Bug] testMath fails on Pangea3
Describe the bug teshMath fails on Pangea3 because 2Pi != 0 Maybe adding a modulo would help
To Reproduce Build and run tests on Pangea3 using host-config from repository
Expected behavior Test should pass.
Screenshots
/appli_RD/LACOSTE/GEOSX/GEOSX2/src/coreComponents/LvArray/unitTests/testMath.cpp:569: Failure
Expected: (maxDiff.get()) < (3 * float( NumericLimitsNC< __half >{}.epsilon )), actual: 6.28222 vs 0.00292969
Max difference is 6.28221765e+00
Max relative difference is 1.24008826e-03
[ FAILED ] TestHalfMath.atan2HalfAccuracy (47 ms)
[ RUN ] TestHalfMath.atan2Half2Accuracy
/appli_RD/LACOSTE/GEOSX/GEOSX2/src/coreComponents/LvArray/unitTests/testMath.cpp:627: Failure
Expected: (maxDiff.get()) < (3 * float( NumericLimitsNC< __half >{}.epsilon )), actual: 6.28222 vs 0.00292969
Max difference is 6.28221774e+00
Max relative difference is 1.50966642e-03
[ FAILED ] TestHalfMath.atan2Half2Accuracy (39 ms)
[----------] 6 tests from TestHalfMath (139 ms total)
[----------] Global test environment tear-down
[==========] 102 tests from 13 test suites ran. (421 ms total)
[ PASSED ] 100 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] TestHalfMath.atan2HalfAccuracy
[ FAILED ] TestHalfMath.atan2Half2Accuracy
Platform (please complete the following information):
- Machine Pangea3
- Compiler: gcc 8.4.1
- GEOSX Version develop