GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

Update caliper and improve output

Open wrtobin opened this issue 4 years ago • 2 comments

We need to update caliper to include a fix related to the time history output.

Additionally when we update we want to rebuild with improved column output support.

Also we want to modify the mark function macro in order to discriminate between overloaded functions, and include template parameter information where appropriate.

wrtobin avatar Jul 28 '20 17:07 wrtobin

Caliper was updated in the TPLs prior to the initial time-hist functionality merge, but I don't think the caliper function-marking macro to account for overloaded functions and multiple instantiations of the same template function as caliper scope symbols are currently either user-provided strings or function names (sans parameters/template parameters) with namespace scoping included.

wrtobin avatar Jul 16 '21 16:07 wrtobin

While working on this it would probably be good to re-instrument the packing functions now that they're largely async, in order to more accurately reflect their performance, as the current instrumentation only captures the unpacking performance adequately.

wrtobin avatar Jul 16 '21 16:07 wrtobin

@wrtobin Do you think that the TPL upgrade of caliper in https://github.com/GEOS-DEV/thirdPartyLibs/pull/200 solves the caliper part of the issue?

TotoGaz avatar Jun 27 '23 01:06 TotoGaz

Yeah the first 2 ticks can be resolved, especially since for critical profiling I usually retain the full caliper database now instead of just the stdout report. Don't think our mark macro discriminates between overloaded functions yet, not least that I recall.

wrtobin avatar Jun 27 '23 15:06 wrtobin

@wrtobin any update?

paveltomin avatar Sep 20 '23 23:09 paveltomin