CANdevStudio icon indicating copy to clipboard operation
CANdevStudio copied to clipboard

Published 20 hours ago • verified publisher icon GENIVI

Extended IDs LSB Truncated.

Open 8bitgeek opened this issue 5 years ago • 10 comments

I'm having an issue with the LSB being truncated. As you can see all the IDs have LSB 0x00 when in fact many of them should not be zero. Is there something I need to be aware of?

CANdevStudio-ExtendedIDsTruncated

8bitgeek avatar Jun 01 '20 07:06 8bitgeek

I have the same issue with J1939 ID, checking around in the code but stand still :(

sangngocle avatar Jun 04 '20 13:06 sangngocle

@8bitgeek @SNL5943 Could you share DBC file you are loading?

rkollataj avatar Jun 05 '20 10:06 rkollataj

extended-ids.dbc.zip

8bitgeek avatar Jun 05 '20 12:06 8bitgeek

It looks like a problem with CANdb (3rdParty/CANdb submodule). I believe that below patch will solve the problem. I need to make sure with @btaczala (CANdb maintainer) if that's correct fix. @8bitgeek @SNL5943 Give it a try and let me know.

https://gist.github.com/rkollataj/28865272b1ed7791f8817484bad458c7

rkollataj avatar Jun 05 '20 13:06 rkollataj

@8bitgeek can I include dbc file into DBC repo (for testing purposes)?

btaczala avatar Jun 06 '20 22:06 btaczala

@rkollataj : Yes, the issue is solved by your patch. Thanks!!

sangngocle avatar Jun 08 '20 14:06 sangngocle

The extended ids appear to be fixed.

However, now I have this issue where the CanSignalSender Value ranges are incorrect. Many of them read "min: 0 max: 0" which is incorrect.

candevstudio-wrong-ranges candevstudio-wrong-ranges1

8bitgeek avatar Jun 10 '20 08:06 8bitgeek

You're right. For CANParkBrakeStatus it should be min 0 and max 3. Was it like that before the patch or patch has broken this?

rkollataj avatar Jun 10 '20 08:06 rkollataj

I worked before. I appears to me that the patch broke this.

8bitgeek avatar Jun 10 '20 12:06 8bitgeek

@8bitgeek @btaczala Have you tried with latest v1.2.2 ?

jogo- avatar Jul 03 '21 11:07 jogo-