GDevelop-extensions
GDevelop-extensions copied to clipboard
GDevelopApp
Add resource loading tools extension
Example file: load-from-url.zip
Adds a few actions that have something to do with loading resources.
Points of importance for the review:
- A private JS variable is being used in the action for audio resources, which is not acceptable. My implementation of the audio one is generally meh in my opinion, I think we probably would remove it unless you think it is essential to keep. Other actions are good.
- The name is kind of bad.
- The extension is maybe not focused enough.
- It uses parameter types not officially supported by events-based extensions. They work just fine without hacks in JavaScript though, only real downside is that if you select another type for those fields while editing the extension you will be stuck unable to go back unless you modify the JSON directly or redownload the extension. I think that this is fine but you may think otherwise.
Is the video can be supported? I made a tiny tweak to be able to show to entropy how to do, by changing the object type in LoadURLIntoSprite function, it's maybe optimal but it works.
Thanks for getting this moving :)
They work just fine without hacks in JavaScript though, only real downside is that if you select another type for those fields while editing the extension you will be stuck unable to go back unless you modify the JSON directly or redownload the extension. I think that this is fine but you may think otherwise.
I think that's fine!
A private JS variable is being used in the action for audio resources, which is not acceptable. My implementation of the audio one is generally meh in my opinion, I think we probably would remove it unless you think it is essential to keep
I would remove this yes, as this can be brittle.
The extension seems not to provide though:
- error handling (what happens if something can't be loaded?)
- conditions to check/know when something has finished loading or errored.
