GDevelop-extensions icon indicating copy to clipboard operation
GDevelop-extensions copied to clipboard

[Auto PR] New extension: Volume Falloff

Open github-actions[bot] opened this issue 3 years ago • 4 comments

Description

This is a basic volume falloff, implemented by lerp'ing based on the distance between a "source" and a "target."

This is for the platformer example.

How to use the extension

Can be used when you want to have a sound louder the closer you are to it.

Note

You'll notice that the expressions for the actions are one-liners. This was to avoid using variables where they are unnecessary.

I am not super familiar with the protocol for GDevelop extensions, so if we'd rather create a few variables in the extension to make the extension's actions more readable, let me know :)

Checklist

  • [X] I've followed all of the best practices.
  • [X] I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.

Example

Platformer_v_1_0_2.zip

Extension file

VolumeFalloff.json.zip

github-actions[bot] avatar Feb 18 '22 01:02 github-actions[bot]

You'll notice that the expressions for the actions are one-liners. This was to avoid using variables where they are unnecessary.

I am not super familiar with the protocol for GDevelop extensions, so if we'd rather create a few variables in the extension to make the extension's actions more readable, let me know :)

mxsdev avatar Feb 18 '22 01:02 mxsdev

Hello @charburgx

You can assign the extension to the Audio category (even is it's not suggested, I fix it in this PR)

image

Last thing is the units and long descriptions are missing on parameters. image

  • Always a period at the end of a long description.
  • Add in long descriptions From 0 to 100, 100 by default (like for existing audio action)
  • Channel -> Channel identifier (like for existing audio action with channels)
  • Max Distance, Must specify the unit in pixels if possible in long description and at the end of event sentence.
  • Source Object -> Source object keep consistency on all parameters, Capital Letters or not, usually we do without.

Bouh avatar Mar 09 '22 22:03 Bouh

Hello @mxsdev 👋

A review has started for this extension, but a new option has presented itself in the meantime. We now have a list of unreviewed "Community extensions", and your extension can be added to it, bypassing the review phase.

If you chose to not take a review, you need to keep the following in mind:

  • As of now, community extensions are not yet shown to users, but they should be until next update
  • Community extensions will never be shown to GDevelop users directly, they will have to check a checkbox for them to be shown
  • All community extension have a warning about them being unstable and unreviewed displayed on their store page
  • Your extension will be added immediately, no question asked, and without you needing to do any changes to your extension
  • You will still need to make an extension that passes the bot's tests (meaning you still should respect the extension best practices)

tl;dr You will not need to do any more (or only minimal) work on your extension, but it might not meet the standards of all users, and reach less users.

If you chose to continue on with the review:

  • The reviewing process might require of you to make some changes to your extension until it meets our reviewer's standards
  • Your extension will reach more users
  • You will be delivering a better extension to the community
  • It will take a bit more time for your extension to be added to the store

tl;dr You will need to do a bit more work but deliver a high quality contribution that will reach more people

The choice is yours, please tell us how you would like to continue.

arthuro555 avatar Jul 03 '22 14:07 arthuro555

Hello @mxsdev 👋

It seems you never responded to our messages. Without hearing back from you, we sadly cannot continue the submission process. Please respond in the next 10 days, or we will assume you will not come back and have to close this submission.

Thanks!

arthuro555 avatar Jul 24 '22 15:07 arthuro555