GDevelop-extensions icon indicating copy to clipboard operation
GDevelop-extensions copied to clipboard

[Auto PR] New extension: HasLanded(for PlatformerObject behaviour)

Open github-actions[bot] opened this issue 3 years ago • 8 comments

Description

this extension checks if an object(which has PlatformerObject behavior) has landed on the floor

here is a playable example https://liluo.io/instant-builds/f4559a13-797a-4c3d-8339-b8aafdaf71ae

How to use the extension

  1. open or create a project(well basically a platformer game will do(as long as the object you wanna check if landed has the platform object behavior
  2. create an event
  3. add the condition "HasLanded"
  4. setup the condition to how you like it
  5. test

Checklist

  • [X] I've followed all of the best practices.
  • [X] I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.

Example

Example

Extension file

Extension

github-actions[bot] avatar Feb 03 '22 00:02 github-actions[bot]

I guess that it's a bit similar to what he describe as "trauma" in this video: https://www.youtube.com/watch?v=tu-Qe66AvtY

If you want, you could take some inspiration from the video to add features to your example. For instance:

  • Implement a "trauma" behavior.
  • Increase the trauma according to the "has land" extension.
  • Use the screen shack extension with the trauma behavior.
  • Explore how the screen shack extension could be used with the noise extension to do a screen shack based on noise.

D8H avatar Feb 09 '22 22:02 D8H

I guess that it's a bit similar to what he describe as "trauma" in this video: https://www.youtube.com/watch?v=tu-Qe66AvtY

If you want, you could take some inspiration from the video to add features to your example. For instance:

  • Implement a "trauma" behavior.
  • Increase the trauma according to the "has land" extension.
  • Use the screen shack extension with the trauma behavior.
  • Explore how the screen shack extension could be used with the noise extension to do a screen shack based on noise.

hmm this is not a trauma extension but its 100% possible todo screen shake(i assume shack means shake) this and stuff like that but I assume I could make some values as expressions(but this means it would need to be a behaviour I believe, but the trauma idea is not the point of the extension the point is to check if the player has landed on the floor(with options) also by trauma I'd assume you mean like health stuff as in player cant move for seconds and screen shake and stuff like that, which is 100% possible right now(but will require actions(like screen shake and as you see in my examples) also I did try to add a max value allowed(so it wouldn't need to be inverted and just have 1 condition but i couldn't do it), though I am looking for ideas to add to the extension(ideas like expressions or more values(like for example there's fall distance and fall speed))

shadow00dev avatar Feb 09 '22 22:02 shadow00dev

Hello @shadow00dev Thanks for submitting this cool extension :3 I took a deep look at it and found few things you should fix: 1- Please comment your example and extension, so anyone taking a look inside can understand how the extension works 2- In the extension description, please make it short for example: from what you have to > Checks if the object has landed on a given floor.

to add notes and more descriptions, for each parameter add (Long description) under it. and remove the spaces after every line. 3- Change extension description from (Checks if the object has landed on to floor.) to (Checks if the object has landed on floor.) 4- Tags should refer to what the extension name is change them to Landed, floor 5- Change the extension version to 1.0.0 as its the first version of the extension, and update it later on 6- Set the category to Advanced 7- Extension parameters first letter is capital letter, then small, for example: MustHaveJump > Must have jump 8- There is no need to show the behavior name in the extension sentence. 9- Change the extension sentence from (HasLanded: Object - PARAM1 PARAM2 - Type -PARAM3 - FallDistance - PARAM4 - FallSpeed - PARAM5 GivenFloor- PARAM6) to (PARAM1 Has landed,On PARAM6, At fall distance PARAM4, And fall speed PARAM5,At PARAM3 type)

same thing to other function naming just without a given floor.


Thanks again for your hard work ❤️ Looking for more extensions and updates from you 😉

VegeTato avatar Apr 22 '22 11:04 VegeTato

hello, i kinda stopped doing anything game dev related, but today ill try to get these changes in, also for descriptions I'm not good at that stuff

shadow00dev avatar Apr 22 '22 15:04 shadow00dev

hello, I realized the extension itself has been commented on but not the example(by this I mean the example doesn't have comments but the extension does) and I'm unsure how to comment on it as I'm not good at this stuff(this is the last thing I need to do on the list you gave I believe), also I think this example is just to show on here how it can be useful not a thing for GDevelop examples right?

shadow00dev avatar Apr 22 '22 17:04 shadow00dev

HasLandedExtensionAndExample.zip

anyway here is the file for both example and extension with the changes

i copied the todo list thing you had on msg form to trello so ill give a image of what i completed

Screenshot 2022-04-22 185130

also if you want me to try to do the comment thing, please explain on how i can do it like give some clues on how to do it as i don't know how to describe stuff that good

shadow00dev avatar Apr 22 '22 17:04 shadow00dev

Hello @shadow00dev 👋 !

A review has started for this extension, but a new option has presented itself in the meantime. We now have a list of unreviewed "Community extensions", and your extension can be added to it, bypassing the review phase.

If you chose to not take a review, you need to keep the following in mind:

  • As of now, community extensions are not yet shown to users, but they should be until next update
  • Community extensions will never be shown to GDevelop users directly, they will have to check a checkbox for them to be shown
  • All community extension have a warning about them being unstable and unreviewed displayed on their store page
  • Your extension will be added immediately, no question asked, and without you needing to do any changes to your extension
  • You will still need to make an extension that passes the bot's tests (meaning you still should respect the extension best practices)

tl;dr You will not need to do any more (or only minimal) work on your extension, but it might not meet the standards of all users, and reach less users.

If you chose to continue on with the review:

  • The reviewing process might require of you to make some changes to your extension until it meets our reviewer's standards
  • Your extension will reach more users
  • You will be delivering a better extension to the community
  • It will take a bit more time for your extension to be added to the store

tl;dr You will need to do a bit more work but deliver a high quality contribution that will reach more people

The choice is yours, please tell us how you would like to continue.

arthuro555 avatar Jul 03 '22 14:07 arthuro555

I would like a review for the extension, I would like it in the same lane as it was before if possible as I've been waiting in that lane for a long time

I'm okay with doing extra work even though i don't do anything game dev/programming/gdevelop related stuff now, also pls tell me what to do like with the extension after review like a list if what i did wrong

if you wanna talk to me on discord its shadow00dev#1481

shadow00dev avatar Jul 03 '22 16:07 shadow00dev