GDevelop-examples icon indicating copy to clipboard operation
GDevelop-examples copied to clipboard

[Isometry] Simplify events

Open D8H opened this issue 1 year ago • 3 comments

  • Use a dedicated extension to change animation according to movement direction.
  • Fix collision masks for sound effects.
  • Use the navigation mesh path finding extension for mouse control.

D8H avatar Dec 05 '22 08:12 D8H

Preview the game(s) changed or added in this Pull Request

  • https://editor.gdevelop.io?project=https://raw.githubusercontent.com/GDevelopApp/GDevelop-examples/nav-mesh-isometry/examples/isometric-game/isometric-game.json

This is an automatic message displaying links to the games in this PR - double check the JSON in case of doubt.

github-actions[bot] avatar Dec 05 '22 08:12 github-actions[bot]

Suggestions:

  • Remove Base_Event (an empty external event)
  • Using a keyboard movement while a mouse movement is in progress causes Mindy to freeze the animation (this is an unlikely use-case)
  • Change navmesh shape-painter to be more visible. Full opacity, color red, and width 2 pixels. This is supposed to stick-out and be highly visible. image
  • Change the animation based on the name instead of number. "idle" is easier to understand than animation "0". (This does not apply to the movement function that requires the number)
  • If we are going to have footstep sounds in the grass, we need them for all types of terrain (at least a default sound for non-grass)
  • "Move with Gamepad" is great and should be included in default controls of the top-down behavior (yes, the Gamepad extension would need to be installed by default).
  • Having two completely different "Is moving" conditions is very confusing (users have to observe the different icon and know the context of each condition) image
  • Add a TriggerOnce to stop the audio for footsteps (otherwise the debugger complains every frame)
  • Why does the bat follow a point called origin? Isn't that the same as Mindy.X()? Why is it not capitalized like it is in the point editor? My recommendation is to create a new point for the bat to follow, instead of origin + offset. image

tristanbob avatar Dec 08 '22 06:12 tristanbob

  • Change navmesh shape-painter to be more visible. Full opacity, color red, and width 2 pixels. This is supposed to stick-out and be highly visible.

I think it's visible enough. If someone take a screenshot of it, at least it won't look too bad.

  • Change the animation based on the name instead of number. "idle" is easier to understand than animation "0". (This does not apply to the movement function that requires the number)

    • Having two completely different "Is moving" conditions is very confusing (users have to observe the different icon and know the context of each condition)

Animation numbers are calculated, I moved it in the function to clarify.

  • If we are going to have footstep sounds in the grass, we need them for all types of terrain (at least a default sound for non-grass)

There is no foot steps sound in the resources of this example. Do you think the one from the platformer example could do?

  • "Move with Gamepad" is great and should be included in default controls of the top-down behavior (yes, the Gamepad extension would need to be installed by default).

I submitted an extension update.

  • https://github.com/GDevelopApp/GDevelop-extensions/pull/690

Thanks for the review, I applied the other suggestions.

D8H avatar Dec 10 '22 21:12 D8H

I think there is no blocking issue. I'll merge it in a few days if nobody see something else to change.

D8H avatar Dec 17 '22 21:12 D8H