learn-gdscript icon indicating copy to clipboard operation
learn-gdscript copied to clipboard

fix: reverse logic, should checked that desired_inventory has all keys

Open Wolfy7 opened this issue 1 year ago • 2 comments

Please check if the PR fulfills these requirements:

  • [x] The commit message follows our guidelines.
  • For bug fixes and features:
    • [x] You tested the changes.

Related issue (if applicable): #904

New feature or change

What is the current behavior?

See #904 App will crash due to error:

Invalid get index 'extra' (on base: 'Dictionary').

What is the new behavior?

App will not crash and tests will fail correctly.

image

Wolfy7 avatar Oct 16 '24 12:10 Wolfy7

Thank you very much for taking the time to fix bugs here! I'm sorry I'm not getting back to you quickly; I was at the Godot conference this weekend and came back sick. I'll test and merge your contributions as soon as possible.

NathanLovato avatar Oct 16 '24 14:10 NathanLovato

Thank you very much for taking the time to fix bugs here! I'm sorry I'm not getting back to you quickly; I was at the Godot conference this weekend and came back sick. I'll test and merge your contributions as soon as possible.

No worries. Take your time.

Nice, hope it was a nice trip / event the Godot conference but sad to hear that you came back sick. Get well soon

Wolfy7 avatar Oct 16 '24 14:10 Wolfy7

Thanks so much once again! I'm very grateful that you're taking the time to make this app better for everyone.

NathanLovato avatar Oct 24 '24 09:10 NathanLovato

Oh no, I have to thank you. For making this software open source so that people like me, for example, can learn from it and with it.

Wolfy7 avatar Oct 24 '24 14:10 Wolfy7