godot-power-pitch icon indicating copy to clipboard operation
godot-power-pitch copied to clipboard

Published 20 hours ago • verified publisher icon GDQuest

Arabic Translation

Open kalmufti opened this issue 6 years ago • 11 comments

I will work on the Arabic translation. Great project thanks @NathanLovato!

kalmufti avatar Oct 15 '18 20:10 kalmufti

I'm having an issue, Arabic is not being displayed on the slides, think maybe I need to add Arabic font? I've noticed the fonts directory but I'm not sure if I just need to add a font there or do I also need to update settings/scripts?

kalmufti avatar Oct 16 '18 03:10 kalmufti

You need some code for that too. Give me a moment, I'll add that. Which locales should use this font?

NathanLovato avatar Oct 16 '18 04:10 NathanLovato

Cool thanks! Locales = ar.

kalmufti avatar Oct 16 '18 04:10 kalmufti

Just added an arabic font as a fallback. Please check and tell me if it's working. If not, could you translate a slide or two and just send me the csv file? so I can test this and fix the display directly

NathanLovato avatar Oct 16 '18 04:10 NathanLovato

See https://github.com/GDquest/godot-slides/commit/5e6e5046bf14fb0ee8a4df2d6fa921f4f3ffee2b

NathanLovato avatar Oct 16 '18 04:10 NathanLovato

Check the second slide, the title still not showing though the text on the left is working but disjointed, in Arabic the words are joined just like writing cursive in English.

PowerPitch.csv.zip

kalmufti avatar Oct 16 '18 16:10 kalmufti

As far as I know Godot doesn't support ligatures and complex font rendering as of yet: https://github.com/godotengine/godot/issues/9961 So it can display various languages but the characters may be disjointed at times.

NathanLovato avatar Oct 17 '18 04:10 NathanLovato

Pushing a fix now, that's the best we'll get for the moment

image

NathanLovato avatar Oct 17 '18 05:10 NathanLovato

There you go, please update the project to the latest master ( 6cb67aa )

NathanLovato avatar Oct 17 '18 05:10 NathanLovato

Hi, any update on this issue or should I close it?

NathanLovato avatar Jan 25 '19 01:01 NathanLovato

Hi Nathan, I've already done most of the translations, was waiting for this work https://github.com/godotengine/godot/pull/21791 to be merged to 3.1 but it seems they pushed it to 3.2. I guess I can finish the translation, push the change to you and have there until we can test on 3.2, because as of the current state it's unreadable.

kalmufti avatar Jan 25 '19 03:01 kalmufti