vitty-app icon indicating copy to clipboard operation
vitty-app copied to clipboard

Feature: Display Lab courses as courseName + Lab

Open 1407arjun opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. Not a problem actually, but an enhancement. Notifications can be more specific in case of a lab, we do not know if its a reminder for a lab or a theory lecture.

Describe the solution you'd like Depending on the slot, we could append a "Lab" to the end of the course name, if the slot is a lab slot.

Will you be working on this feature?

  • [x] Yes
  • [ ] No

Have you talked with any inner-core member regarding this feature?

  • [ ] Yes
  • [x] No

1407arjun avatar Mar 02 '22 10:03 1407arjun

Hey @1407arjun,

There's a problem with this approach of additing Lab blindly at the end of a course name and that is that some courses have the word "Lab" in the course name itself.

For example, "Calculus Lab". If we use this method, the course name would become "Calculus Lab Lab".

iamyajat avatar Mar 02 '22 10:03 iamyajat

Oh okay @iamyajat. So I have a solution for this. The problem that you have mentioned occurs for the current first year students since their curriculum is different. We can differentiate that by checking for the course code, since all the courses in the new curriculum are of length 8 and of length 7 in the old one. I can make these changes in the PR if its appropriate.

We would be the last batch using this feature tho 😅

1407arjun avatar Mar 02 '22 11:03 1407arjun

We can easily eliminate that by checking if the course has a time for 1hr 40 min and if there is a 'Lab' in their name dont add lab if there isn't add lab

SoumilB7 avatar Dec 07 '22 04:12 SoumilB7

closing as an old issue

dk-a-dev avatar Dec 15 '24 16:12 dk-a-dev