sbire icon indicating copy to clipboard operation
sbire copied to clipboard

OSX compatibility

Open julienXX opened this issue 12 years ago • 7 comments

  • [x] Handle multiple operating systems
  • [x] Use sox & terminal-notifier for OSX
  • [ ] Move from ExternalTools to a config file
  • [ ] Make the binary more UNIX-y (help with no args...)
  • [ ] Add an install command (prepare ~/.sbire ans so on)
  • [ ] Update README

Work in progress, not ready to be merged yet but here's the pull-request so that you can see what's coming.

julienXX avatar Nov 01 '13 17:11 julienXX

Thanks a lot! I will merge it whan you are ready.

GCorbel avatar Nov 01 '13 17:11 GCorbel

What do you think about to externalize commands called by Sbire. We could add, in the config file, this :

commands:
  notifier: "notify-send %{message}"
  recorder: "ffmpeg ... %{file_path}"

We can also create a default file for different systems. I can also be intersant to do a "install" command to create files and directories.

It is simpler for us, because we don't need to manage all commands made by the system, and more flexible for the use.

What you think?

GCorbel avatar Nov 01 '13 20:11 GCorbel

Yeah that was the purpose of the ExternalTools class, but a yaml file is okay too. It would allow more customization from the users and perhaps more issues too. We need to manage the commands used by Sbire a bit, just enough to at least provide a working template (ffmeg options and so on). And +1000 for the install command, sbire is not user friendly at the moment.

julienXX avatar Nov 01 '13 21:11 julienXX

We can prepare a default file for each systems. For now, ffmpeg is mandatory because it's used by speech2Text but, I will be happy to remove it from the project. It is a probably something I will do later.

GCorbel avatar Nov 01 '13 21:11 GCorbel

any progress? I'm getting sbire/notifier.rb:4:incall': undefined method %' for nil:NilClass error when running under mac os x

onemanstartup avatar Dec 09 '14 01:12 onemanstartup

@julienXX , can you try to update your pull request. @onemanstartup, can you try if this work : https://github.com/julienXX/sbire/commit/43cf75aeb7a2678aa5aa40c2c291d74b5fe2ee76 ?

GCorbel avatar Dec 09 '14 12:12 GCorbel

I'll try to find some time to update it :)

julienXX avatar Dec 09 '14 13:12 julienXX