Guirec Corbel comments

Results 127 comments of


                                            Guirec Corbel

Exclude stubbed classes from subclasses after teardown

I change to run specs only for Ruby 3.1 and ahead as in https://github.com/rails/rails/blob/v7.0.8/activesupport/lib/active_support/ruby_features.rb

Exclude stubbed classes from subclasses after teardown

Sorry, my latest commit was completely broke. I fixed it.

Exclude stubbed classes from subclasses after teardown

I fixed the code for Ruby

Exclude stubbed classes from subclasses after teardown

The CI pass except for "ruby-head" which is not to my commit

Exclude stubbed classes from subclasses after teardown

I fixed a flap on specs. Now the CI should pass.

Exclude stubbed classes from subclasses after teardown

I finally succeeded to install Ruby 3.4-dev locally and confirm that the error on the CI is not related to the PR. It also fail on the main branch.

Exclude stubbed classes from subclasses after teardown

Hello, I don't want to bother you but is it possible to have a quick review, at least on the global behavior? I'm waiting for this to be able to...

Exclude stubbed classes from subclasses after teardown

> Please accept my apologies for the wait. The code is mostly good, thanks! No problem, it's open source. You don't even have to reply.

Exclude stubbed classes from subclasses after teardown

@JonRowe can you give a look at this request ?

`stub_const` doesn't clear `Class#subclasses`

It seems that doing a garbage collection after `RSpec::Mocks.teardown` fix the issue. ``` class Something; end describe 'Test' do before(:each) do class A < Something; end stub_const('B', Class.new(Something)) end after(:each)...