GCHQDev404

gh-2357 FederatedStore federated operation

1

# Related Issue - Resolve #2357

FederatedStore Review IT tests

1

Some tests could be pulled out IT. Some tests could be in ITS class using a different "publicAccessPredefinedFederatedStore" with zero graphs?

Remove view Edge Entity Validation for operations

1

Following the bug raised and fixed in gh-1992. Should the views been validated at all? Can the view validation be removed completely and opChains simply return null if the view...

FederatedStore isAddingUser rename

1

Braking change. change isAddingUser and similar reference to isCreatingUser

FederatedStore-FederatedAccess: Why are Read Write Predicates Strings and not AccessPredicate objects?

7

FederatedStore-FederatedAccess: Why are Read Write Predicates Strings and not AccessPredicate objects? This requires deserialisation on every usage of FederatedAccess on graphs, This seems wasteful.

Refactor existing hashCode() to include class for methods using the Apache Commons Lang 3 style

3

Append `class` to all `HashCodeBuilders` in Gaffer for the below issue to minimise hash collisions. ``` @Test void name() { Foo foo = new Foo(); Bar bar = new Bar();...

ProxyStore remove the Switch statement

2

Recursion of the opChain is no longer required and adds complexity. doOperation -> Unprocessed Logic -> ResolvedLogic -> ToHandlers OR ToProxy

Previously there have been bug in `FederatedStore` regarding options map being shared between operations/stores example see gh-2445. This was fixed with a deep clone of `JSONSerialisation` which is a little...

AddNamedOperation InputType

1

When querying `GetAllNamedOperations` the field `InputType` is created and populated into the `NamedOperationDetail` object during the logic of `GetAllNamedOperationsHandler`. Why is this not created and added to the named operation...

FederatedStore FederatedGraphStorage has Accumulo specific code

4

The Accumulo specific code in FederatedGraphStorage fixes mismatch in tables and graph name. 1. Does a similar problem effect other stores? 2. Does this code belong somewhere else Possible Likely...