NotebookNavigator.nvim icon indicating copy to clipboard operation
NotebookNavigator.nvim copied to clipboard

`run_cell` with toggleterm backend does not send indentation lines over

Open raffaem opened this issue 1 year ago • 2 comments

The run_cell function with the toggleterm backend does not send indentation line over.

Here is a screencap.

The first time I use NotebookNavigator to send the cell to the REPL.

The second time I use toggleterm directly.

20240226T121036.webm

raffaem avatar Feb 26 '24 11:02 raffaem

Looks like the responsible is here: https://github.com/GCBallesteros/NotebookNavigator.nvim/blob/main/lua/notebook-navigator/repls.lua#L18?

@GCBallesteros why this line? Can I send a PR that removes it?

raffaem avatar Feb 26 '24 11:02 raffaem

yeah, changing that line fixes the issue, although newlines break cells so they have to be filtered out, and ipython has to be run with ipython --no-autoindent If anyone gets here and wants to test it out here's the fork I use (just those small changes): https://github.com/jonboh/NotebookNavigator.nvim/tree/34dc9b6f3bb72e5430e5307af006a73be814ae3e

jonboh avatar Apr 03 '24 19:04 jonboh

@raffaem Was this fixed by your recent PR #40?

GCBallesteros avatar May 23 '24 13:05 GCBallesteros

@raffaem Was this fixed by your recent PR #40?

Looks like so

raffaem avatar May 24 '24 21:05 raffaem