bitcoin-wallet-ui-kit icon indicating copy to clipboard operation
bitcoin-wallet-ui-kit copied to clipboard

Introduce button states?

Open GBKS opened this issue 1 year ago • 1 comments

We created a whole set of states (hover, active...) for buttons in the Bitcoin Core App (see in Figma here). Do we want to port those over to the UI Kit?

If so, is it maybe time to split the Button into several sub-components to make them easier to manage. We have lots of configurations (3 sizes, 3 styles, 5 states, 4 content variations = 180). There is complexity, the question is just where do we put it.

  • One massive Button component with lots of properties (as we have now)?
  • Multiple components (IconButton, TextButton, TextIconButton, IconTextButton) that are almost interchangeable?

My initial hunch is to keep components simple (fewer properties) so there's less hidden (less guessing) and less explanation (spec sheets) needed. But let's discuss.

A follow-up discussion would be to document the standard treatments for focus, hover... and which other components would need updating.

GBKS avatar Jan 20 '23 07:01 GBKS