Oleg

Results 60 comments of Oleg

What rails version does that? Looking at current master `options[:multiple]` should not propagate to the hidden field. See: https://github.com/rails/rails/blob/20c91119903f70eb19aed33fe78417789dbf070f/actionview/lib/action_view/helpers/tags/check_box.rb#L23 Also, is it even possible to bootstrap wrap `collection_check_boxes` helper? There's...

Oh yeah. They are just being overridden. That makes sense. About leaking options I raised issue here: https://github.com/bootstrap-ruby/bootstrap_form/issues/386

I finally understand what the issue is. ``` hidden_field(method, multiple: true, value: "") ``` This will append `[]` to the name attribute and still will generate `multiple="multiple"` attribute. It seems...

I fixed by changing API like so: ``` f.text_field :foo, append: "Text" f.text_field :foo, append: { html: "Submit".html_safe } ``` By default it will wrap text in the `input-group-text`. If...

This is not even about Yard docs. It's about having helpful documentation so it's possible to figure out what a given method does. Methods like these: https://github.com/bootstrap-ruby/bootstrap_form/blob/master/lib/bootstrap_form/form_builder.rb#L106 have way too...

I think this could be a thing. Bootstrap 4 allows setting predefined `invalid-feedback` on form elements for JS validation. See: https://getbootstrap.com/docs/4.0/components/forms/#validation I makes sense to allow setting it to whatever...

@mattbrictson did you see my PR #387 ? I literally removed it without consequence in like 5 minutes.

@mattbrictson I can add entry in the readme. Any thoughts about the option that immediately calls `super`? That way you don't need to worry about `fields_for`. I just don't want...

Knowing that library they use is not bloated, free of bugs and trivial to maintain to ensure future compatibility.

If this doesn't get removed for 4.0.0, it will never going to be removed 🤷‍♂️