bot
bot copied to clipboard
stdin commands for The Hosts
Implements the stdin commands into GAB.
ignore this pr for now; we still working on it
will fix
Multiple complaints:
- Client when this will run on the sharder?
- That is not how you do jsdocs comments.
:thinking:
I may have solutions on these:
- We may require() this off the sharder or just on the first shard
- My bad for
{CLI]
- I'd say allow us to choose the shard and then, and then run commands on it.
- No. You don't get it. Those are not jsdoc comments, those start with
/**
I disagree with point 1.
STDIN is only captured on the master process as the streams of the workers are only accessible by IPC. I recommend we use IPC in command functions when needed to contact shards, apart from that, this module should only run on the master process.
github can you show me some wuv
i've merged that already :(
Please use rebase when merging branches.
I'd like to repeat that the STDIN is not reachable from any shards. This means that you can only listen for incoming commands in the master process, so it's currently pointless to require a Discord Client object in the module.
:ok_hand: Got it
Will tamper with that later.
@GilbertGobbels Should we at least, require the sharder object or no-no?
note: the stdin thing is actually listening to your keyboard inputs.
I may make it listening to the input after all shards get ready
let's force push it later, now will work on resetting my fuck ups
Reverted the commits.
Switched to CTRL+G.
Reasons:
- CTRL + Z works on Windows, but not on Linux (process gets terminated)
- G for GAB :eyes:
rebasing is a pain
🤔 if I'll sure finish it til 2018
This is how quality my commit descriptions are (No, we don't reload config.json on BigMessage from CLI)
ok will do
Updated the title to use gitmoji.
hope no one burns for writing such a message
@KingDGrizzle @GilbertGobbels 🤔 Should I make more of the stdin commands or uh.. consider this PR done
- ConfigJSON spaces should be 2
- I'd personally like some tests (and documentation?) for some commands
- I'd like to see all commands in action 😄
Otherwise, looks good enough for now. I'll let Gilbert say his opinion
- refactor is coming!
- command help is enough?
$ git clone https://github.com/tttie/gawesomebot -b feature/indev-4.0.2/cli-commands
# fill the config.js and config.json like you normally would
$ node bot
# *gab gets ready*
# type your commands
@KingDGrizzle didn't ping you in the response, so have the ping here
why must documentation be such a pain :/
Also, please go through all eslint warnings for your files, and fix them 😄
my eslint found non3
It's called Travis Builds ;)