flutter_settings_screens icon indicating copy to clipboard operation
flutter_settings_screens copied to clipboard

Fix: Subtitle in RadioModalSettingsTile was not changing after more than two opens.

Open Juggler98 opened this issue 3 years ago • 1 comments

This commit solved this and this, but there was still a little problem with not updating subtitle in RadioModalSettingsTile after more than two opens. Check the video.

But I do not know, if this line was important for some other stuff like handling memory leaks, so merge with caution.

Juggler98 avatar Sep 29 '22 16:09 Juggler98

I changed it to:

@override
  void dispose() {
    if (mounted == false) {
      _notifiers.remove(cacheKey);
    }
    super.dispose();
  }

and it works ok here.

alberto-paiva avatar Oct 16 '22 23:10 alberto-paiva

I changed it to:

@override
  void dispose() {
    if (mounted == false) {
      _notifiers.remove(cacheKey);
    }
    super.dispose();
  }

and it works ok here.

I updated my pull request with this code. It works fine. @GAM3RG33K could you please merge this little change, so the plugin is working properly for everyone? :)

Juggler98 avatar May 31 '24 17:05 Juggler98