flutter_settings_screens icon indicating copy to clipboard operation
flutter_settings_screens copied to clipboard

RTL bug in SettingsGroup

Open mbfakourii opened this issue 3 years ago • 7 comments

Hello, there is a problem in the rtl and in the SettingsGroup widget . Here, instead of using Alignment.centerLeft, AlignmentDirectional.centerStart should be used !

Screenshot

image

mbfakourii avatar Sep 05 '22 05:09 mbfakourii

This is solved in the most recent commit.

Juggler98 avatar Sep 29 '22 16:09 Juggler98

@Juggler98 Can you open a PR for these changes?

mbfakourii avatar Oct 10 '22 08:10 mbfakourii

Hi, it is already merged.

Juggler98 avatar Oct 10 '22 08:10 Juggler98

Hi, it is already merged.

I see now, thanks

mbfakourii avatar Oct 10 '22 08:10 mbfakourii

@GAM3RG33K Can you give a release based on the latest changes?

mbfakourii avatar Oct 10 '22 08:10 mbfakourii

@mbfakourii you can import dependency directly from github:

https://stackoverflow.com/questions/54022704/how-to-add-a-package-from-github-in-flutter

Juggler98 avatar Oct 10 '22 08:10 Juggler98

@GAM3RG33K @Juggler98 The problem still persists. The type of titleAlignment must be of type AlignmentGeometry in order to use AlignmentDirectional!

mbfakourii avatar Dec 20 '22 07:12 mbfakourii